-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins): add realm to removed fields #13042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
May 16, 2024
nowNick
force-pushed
the
fix/backwards-compat-auth-plugin-realms
branch
2 times, most recently
from
May 21, 2024 14:37
4bb59b0
to
357d4d7
Compare
Basic-auth and key-auth added new field "realm" but it was not added to "removed_fields" which breaks backwards compat between new CPs and old DPs. Adding realm to removed fields fixes the issue. KAG-4516
nowNick
force-pushed
the
fix/backwards-compat-auth-plugin-realms
branch
from
May 21, 2024 15:47
357d4d7
to
00abf10
Compare
3 tasks
hanshuebner
approved these changes
May 23, 2024
jschmid1
approved these changes
May 31, 2024
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.6.x
git worktree add -d .worktree/backport-13042-to-release/3.6.x origin/release/3.6.x
cd .worktree/backport-13042-to-release/3.6.x
git switch --create backport-13042-to-release/3.6.x
git cherry-pick -x 420b3b6ceb17d84fb84486e0de72635fb4408c45 |
3 tasks
Successfully created backport PR for |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13042-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13042-to-master-to-upstream
git checkout -b cherry-pick-13042-to-master-to-upstream
ancref=$(git merge-base a11338a8f1ac7f869967fc74660380f11b051bb0 00abf103c277a3c74985b40db6647c615fb9efe6)
git cherry-pick -x $ancref..00abf103c277a3c74985b40db6647c615fb9efe6 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release/3.6.x
backport release/3.7.x
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/clustering
incomplete-backport
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basic-auth and key-auth added new field "realm" but it was not added to "removed_fields" which breaks backwards compat between new CPs and old DPs. Adding realm to removed fields fixes the issue.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4516